Micron Document
🎖️GitЯра🎖️

Node / meshtastic / Meshtastic-Android / commits / 5b19a5f

Commit 5b19a5f31f2be8894c372bbee88532a70002e6a5

󰉖 Browse tree at this commit

Parents : b969346
Author : James Rich <2199651+jamesarich@users.noreply.github.com>
Signature : Signature validation error
Date : 2026-06-17T09:19:25-05:00
Committer : GitHub <noreply@github.com>
Date : 2026-06-17T14:19:25Z

fix(appfunctions): keep AppSearch document-factory constructors under R8 full mode (#5829)

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

Changes

1 files changed, 16 insertions(+), 0 deletions(-)

M androidApp/proguard-rules.pro +16

Diff

diff --git a/androidApp/proguard-rules.pro b/androidApp/proguard-rules.pro
index de2b3144cb..5275274518 100644
--- a/androidApp/proguard-rules.pro
+++ b/androidApp/proguard-rules.pro
@@ -40,6 +40,22 @@
-dontwarn org.bouncycastle.**
-dontwarn org.openjsse.**
+# ---- AppSearch / AppFunctions generated document factories ------------------
+# AppSearch's DocumentClassFactoryRegistry loads the generated
+# `$$__AppSearch__*` factory classes by name and instantiates them via their
+# no-arg constructor (reflection). AppSearch's own consumer rule keeps the
+# factory *class* (`-keep ... class ** implements DocumentClassFactory {}`) but
+# not its members. Under R8 full mode (AGP 8+ default, and we're on AGP 9) a
+# bare `-keep class X {}` no longer implicitly retains the default constructor,
+# so the constructor is tree-shaken and runtime construction fails with
+# NoSuchMethodException — e.g.
+# androidx.appfunctions.metadata.$$__AppSearch__AppFunctionRuntimeMetadata.<init>[]
+# crashing AppFunctionManager.getInstance(). Upstream tracking: b/440484133.
+# Keep the no-arg constructor explicitly until AppSearch's rules cover it.
+-keepclassmembers class * implements androidx.appsearch.app.DocumentClassFactory {
+ <init>();
+}
+
# Compose runtime/ui/animation/foundation/material3 keep rules now live in
# config/proguard/shared-rules.pro so both Android (R8) and desktop (ProGuard)
# get the same defence-in-depth coverage against CMP 1.11 optimizer folding.

Served by rngit 1.5.0 - Generated in 0.05s